 | | | Commented: (XERCESJ-1133) Need increase in visibility for HTMLElementImpl | Commented: (XERCESJ-1133) Need increase in visibility for HTMLElementImpl 2006-02-19 - By Michael Glavassevich (JIRA)
[ http://issues.apache.org/jira/browse/XERCESJ-1133?page=comments#action
_12367002 ]
Michael Glavassevich commented on XERCESJ-1133:
-----------------------------------------------
Jake, I cannot apply the patch you made to AbstractDOMParser because it causes
a performance regression. That one line change causes every component in the
pipeline to read features and properties from the configuration when they
otherwise wouldn't need to. setDocumentClassName(String) is an internal method
which is called during parser reset. The correct way to set the document class
name is to call setProperty() [1] or better yet use JAXP instead by setting the
property on the DocumentBuilderFactory using setAttribute().
I guess you know that the other changes you're asking for aren't in the public
part of the API. You're taking a risk by extending or referencing Xerces'
internals. Any class or interface marked with @(protected) could go away or
have methods on them change in the future. You are prepared for that, right?
[1] http://xerces.apache.org/xerces2-j/properties.html#dom.document-class-name
> Need increase in visibility for HTMLElementImpl constructor
> -----------------------------------------------------------
>
> Key: XERCESJ-1133
> URL: http://issues.apache.org/jira/browse/XERCESJ-1133
> Project: Xerces2-J
> Type: Improvement
> Components: DOM (HTML)
> Versions: 2.7.1
> Reporter: Jacob Kjome
> Attachments: xerces_xmlc-compat.patch, xerces_xmlc-compat2.patch
>
> I am making an attempt to move XMLC ( http://xmlc.enhydra.org/ ) from Xerces1
to Xerces2. I'm currently unable to do that without manipulating the Xerces2
source for a couple of classes because of lack of visibility for a couple of
methods. I don't see any harm that would come from increasing visibility in
either case. The cases are...
> 1. HTMLElementImpl.java - make the constructor public instead of package
private
> 2. DocumentTypeImpl.java - make setOwnerDocument(CoreDocumentImpl) protected
instead of package private (needed for XMLC LazyDOM extension).
> Patch coming up. I hope these can be in Xerces-2.8.0.
> Jake
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@(protected)
For additional commands, e-mail: j-dev-help@(protected)
|
|
|